Add a lift method to LieGenerator #36487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 8b61732; changes) is ready! 🎉 |
tscrim
approved these changes
Dec 20, 2023
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 21, 2023
sagemathgh-36487: Add a lift method to LieGenerator The `FreeLieAlgebraElement.lift` method can try to call both `LieGenerator.lift` and `LieBracket.lift`, but the former is not defined. As a consequence coercion into the universal enveloping algebra fails for elements which are not brackets: ``` sage: L = LieAlgebra(QQ, ['X','Y']).Lyndon() sage: X,Y = L.gens() sage: U = L.universal_enveloping_algebra() sage: U.one() + X.bracket(Y) # works fine 1 + X*Y - Y*X sage: U.one() + X Traceback (most recent call last) ... AttributeError: 'sage.algebras.lie_algebras.lie_algebra_element.Lie' object has no attribute 'lift' ``` Copying the pre-existing code in `LieBracket.lift` to `LieGenerator.lift` with straight-forward modifications (since the generator case is even simpler) fixes this problem. ``` sage: U.one() + X 1 + X ``` URL: sagemath#36487 Reported by: Eero Hakavuori Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 22, 2023
sagemathgh-36487: Add a lift method to LieGenerator The `FreeLieAlgebraElement.lift` method can try to call both `LieGenerator.lift` and `LieBracket.lift`, but the former is not defined. As a consequence coercion into the universal enveloping algebra fails for elements which are not brackets: ``` sage: L = LieAlgebra(QQ, ['X','Y']).Lyndon() sage: X,Y = L.gens() sage: U = L.universal_enveloping_algebra() sage: U.one() + X.bracket(Y) # works fine 1 + X*Y - Y*X sage: U.one() + X Traceback (most recent call last) ... AttributeError: 'sage.algebras.lie_algebras.lie_algebra_element.Lie' object has no attribute 'lift' ``` Copying the pre-existing code in `LieBracket.lift` to `LieGenerator.lift` with straight-forward modifications (since the generator case is even simpler) fixes this problem. ``` sage: U.one() + X 1 + X ``` URL: sagemath#36487 Reported by: Eero Hakavuori Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2023
sagemathgh-36487: Add a lift method to LieGenerator The `FreeLieAlgebraElement.lift` method can try to call both `LieGenerator.lift` and `LieBracket.lift`, but the former is not defined. As a consequence coercion into the universal enveloping algebra fails for elements which are not brackets: ``` sage: L = LieAlgebra(QQ, ['X','Y']).Lyndon() sage: X,Y = L.gens() sage: U = L.universal_enveloping_algebra() sage: U.one() + X.bracket(Y) # works fine 1 + X*Y - Y*X sage: U.one() + X Traceback (most recent call last) ... AttributeError: 'sage.algebras.lie_algebras.lie_algebra_element.Lie' object has no attribute 'lift' ``` Copying the pre-existing code in `LieBracket.lift` to `LieGenerator.lift` with straight-forward modifications (since the generator case is even simpler) fixes this problem. ``` sage: U.one() + X 1 + X ``` URL: sagemath#36487 Reported by: Eero Hakavuori Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
sagemathgh-36487: Add a lift method to LieGenerator The `FreeLieAlgebraElement.lift` method can try to call both `LieGenerator.lift` and `LieBracket.lift`, but the former is not defined. As a consequence coercion into the universal enveloping algebra fails for elements which are not brackets: ``` sage: L = LieAlgebra(QQ, ['X','Y']).Lyndon() sage: X,Y = L.gens() sage: U = L.universal_enveloping_algebra() sage: U.one() + X.bracket(Y) # works fine 1 + X*Y - Y*X sage: U.one() + X Traceback (most recent call last) ... AttributeError: 'sage.algebras.lie_algebras.lie_algebra_element.Lie' object has no attribute 'lift' ``` Copying the pre-existing code in `LieBracket.lift` to `LieGenerator.lift` with straight-forward modifications (since the generator case is even simpler) fixes this problem. ``` sage: U.one() + X 1 + X ``` URL: sagemath#36487 Reported by: Eero Hakavuori Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 25, 2023
The `FreeLieAlgebraElement.lift` method can try to call both `LieGenerator.lift` and `LieBracket.lift`, but the former is not defined. As a consequence coercion into the universal enveloping algebra fails for elements which are not brackets: ``` sage: L = LieAlgebra(QQ, ['X','Y']).Lyndon() sage: X,Y = L.gens() sage: U = L.universal_enveloping_algebra() sage: U.one() + X.bracket(Y) # works fine 1 + X*Y - Y*X sage: U.one() + X Traceback (most recent call last) ... AttributeError: 'sage.algebras.lie_algebras.lie_algebra_element.Lie' object has no attribute 'lift' ``` Copying the pre-existing code in `LieBracket.lift` to `LieGenerator.lift` with straight-forward modifications (since the generator case is even simpler) fixes this problem. ``` sage: U.one() + X 1 + X ``` URL: sagemath#36487 Reported by: Eero Hakavuori Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FreeLieAlgebraElement.liftmethod can try to call bothLieGenerator.liftandLieBracket.lift, but the former is not defined. As a consequence coercion into the universal enveloping algebra fails for elements which are not brackets:Copying the pre-existing code in
LieBracket.lifttoLieGenerator.liftwith straight-forward modifications (since the generator case is even simpler) fixes this problem.