Demote brial (= polybori) from standard to optional, add distribution sagemath-brial, enlarge sagemath-objects, sagemath-categories #36380

mkoeppe · 2023-10-01T20:39:16Z

as proposed in https://groups.google.com/g/sage-devel/c/ewHP20bmskQ, because (among other things):
It has been dropped from Debian testing (debian-trixie) and ubuntu-noble, where it seems to block SageMath upgrades (Sage is stuck at 9.5 in Debian/Ubuntu). See https://repology.org/project/brial/versions

Doctests are already conditional on the dynamically detected feature sage.rings.polynomial.pbori
We create a distribution sagemath-brial that packages the corresponding extension modules (cherry-picked from Modularization of sagelib: Distributions sagemath-{brial,combinat,eclib,flint,gap,giac,glpk,graphs,groups,homfly,lcalc,libbraiding,libecm,linbox,modules,mpmath,ntl,pari,plot,polyhedra,schemes,singular,standard-no-symbolics,symbolics} #35095).
Documentation is conditionalized by using Sphinx tags

The new distribution builds on top of enlarged distributions sagemath-objects, sagemath-categories. This is a major update of these distributions, which makes them much more useful.

Also includes style changes to all*.py files cherry-picked from #37900.

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

Depends on Conditional documentation #36495 (split out from here)
~~Depends on pkgs/sagemath-{objects,categories}: Enlarge #36566 (split out from here)~~
Depends on Replace special handling of optional extensions (bliss, coxeter3, ....) #37857 (merged here)
Depends on Add # sage_setup: distribution directives for the files of existing distributions sagemath-{categories,...,tdlib} #38088 (merged here)
Depends on sage.monoids: Modularization fixes, # needs #38143 (merged here)
Depends on sage.schemes: Modularization fixes (imports) #38142 (merged here)
Depends on sage.interfaces: More lazy_import #38180 (split out from here)
Depends on build/pkgs/sagemath_{categories,environment,objects,repl}: Change to optional #38200

dimpase · 2023-10-02T21:26:10Z

docs don't build. I think one can't build boolean polynomials' docs without brial installed, so this has to be moved out:

--- a/src/doc/en/reference/polynomial_rings/index.rst
+++ b/src/doc/en/reference/polynomial_rings/index.rst
@@ -62,12 +62,4 @@ Infinite Polynomial Rings
    sage/rings/polynomial/symmetric_ideal
    sage/rings/polynomial/symmetric_reduction
 
-Boolean Polynomials
--------------------
-
-.. toctree::
-   :maxdepth: 1
-
-   sage/rings/polynomial/pbori/pbori
-
 .. include:: ../footer.txt

mkoeppe · 2023-10-02T21:49:29Z

Right. We will need to find a solution for this more general problem of building the manual with optional parts...

dimpase · 2023-10-02T22:04:03Z

also:

src/sage/features/sagemath.py:867: UserWarning: Feature sage.rings.polynomial.pbori is declared standard, but it is provided by sagemath_brial, which is declared experimental in SAGE_ROOT/build/pkgs
  JoinFeature.__init__(self, 'sage.rings.polynomial.pbori',

dimpase · 2023-10-03T09:27:37Z

there are several unconditional imports of BooleanPolynomials left, e.g. in
src/sage/rings/polynomial/multi_polynomial_libsingular.pyx

Should it go via an abstract class, etc, to achieve modularity ?

mkoeppe · 2023-10-03T16:29:59Z

there are several unconditional imports of BooleanPolynomials left, e.g. in src/sage/rings/polynomial/multi_polynomial_libsingular.pyx

Should it go via an abstract class, etc, to achieve modularity ?

I think I have already done all necessary changes of this kind in #35095. I'll cherry-pick them to this branch later today.

mkoeppe · 2023-10-03T18:47:15Z

Actually I created the ABC BooleanPolynomialRing_base for the parent, but not for the element class. So if you have chance, a modularizing fix here would be welcome

Edit: Done already in f5c6196

kwankyu · 2023-10-09T11:35:19Z

.gitignore

@@ -215,6 +217,7 @@ build/bin/sage-build-env-config
 /pkgs/sagemath-categories/requirements.txt
 /pkgs/sagemath-environment/requirements.txt
 /pkgs/sagemath-repl/requirements.txt
+/pkgs/sagemath-brial/requirements*.txt
 /pkgs/sagemath-categories/MANIFEST.in



OK for now. But I think this block of lines should be sorted out by distribution names...

.gitignore

build/pkgs/sagelib/dependencies

src/doc/en/developer/packaging_sage_library.rst

pkgs/sagemath-brial/tox.ini

kwankyu · 2023-10-18T04:49:33Z

I get

$ ./sage -sh -c '(cd pkgs/sagemath-brial && tox -v -v -v -e sagepython)'
...
      
            cypari2/closure.pyx:139:4: 'sig_on' is not a constant, variable or function identifier
      
            Error compiling Cython file:
            ------------------------------------------------------------
            ...
      
            cdef int _pari_init_closure() except -1:
                sig_on()
                global ep_call_python
                ep_call_python = install(<void*>call_python, "call_python", 'DGDGDGDGDGD5,U,U')
                sig_off()
                ^
            ------------------------------------------------------------
      
            cypari2/closure.pyx:142:4: 'sig_off' is not a constant, variable or function identifier
      
            Error compiling Cython file:
            ------------------------------------------------------------
            ...
                # Only 5 arguments are supported for now...
                if nargs > 5:
                    nargs = 5
      
                # Fill in default arguments of PARI function
                sig_on()
                ^
            ------------------------------------------------------------
      
            cypari2/closure.pyx:230:4: 'sig_on' is not a constant, variable or function identifier
            Traceback (most recent call last):
...
              File "/private/var/folders/td/fw1q9ljs311ggyph77rs53_40000gn/T/pip-install-h6yasewl/cypari2_0d737fa76b3f479ea5e1b6ab73dffe77/.eggs/Cython-3.0.4-py3.11.egg/Cython/Build/Dependencies.py", line 1321, in cythonize_one
                raise CompileError(None, pyx_file)
            Cython.Compiler.Errors.CompileError: cypari2/closure.pyx
            [end of output]
      
        note: This error originates from a subprocess, and is likely not a problem with pip.
      error: legacy-install-failure
      
      × Encountered error while trying to install package.
      ╰─> cypari2
      
      note: This is an issue with the package mentioned above, not pip.
      hint: See above for output from the failure.
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× pip subprocess to install build dependencies did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.
sagepython: 67309 C exit 1 (66.94 seconds) /Users/kwankyu/GitHub/sage-dev/pkgs/sagemath-brial> python -I -m pip install -r requirements.txt pid=54141 [tox/execute/api.py:275]
  sagepython: FAIL code 1 (66.95 seconds)
  evaluation failed :( (67.15 seconds)

kwankyu · 2023-10-18T06:53:35Z

This src/sage_setup/__init__.py seems new (or copied from somewhere?) What is the intention? Should this

sage: sage_setup.sage_setup(['sagemath-modules'])

work? There's no doc for it...

pkgs/sagemath-brial/sage

github-actions · 2023-10-23T06:14:00Z

Documentation preview for this PR (built with commit 9cba2e8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

sagemathgh-36495: Conditional documentation    Documentation is conditionalized by using Sphinx tags. Split out from (and preparation for): - sagemath#36380 Part of: - sagemath#29705   ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36495 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee

sagemathgh-36511: Exclude symlinks from vscode search config via glob pattern As requested in sagemath#36380 (comment) and cherry-picked from there.      ### 📝 Checklist     - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies   URL: sagemath#36511 Reported by: Matthias Köppe Reviewer(s): Tobias Diez