Skip to content

Make sure the type detection for reducible Cartan types is correct #36346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2023
Merged

Make sure the type detection for reducible Cartan types is correct #36346

merged 3 commits into from
Dec 26, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Sep 27, 2023

We better handle the relabeling of Cartan types when detecting the type from a Cartan matrix. Fixes #35987.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

darijgr
darijgr reviewed Dec 24, 2023
View reviewed changes
@tscrim tscrim force-pushed the root_systems/fix_subtype-35987 branch from 291d5d2 to 2a8d761 Compare December 25, 2023 01:04
@tscrim tscrim added this to the sage-10.3 milestone Dec 25, 2023
@darijgr darijgr assigned darijgr and tscrim and unassigned tscrim and darijgr Dec 25, 2023
darijgr
darijgr approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@darijgr darijgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@tscrim
Copy link
Collaborator Author

tscrim commented Dec 25, 2023

Thank you!

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 152d440; changes) is ready! 🎉

@vbraun vbraun merged commit 602e701 into sagemath:develop Dec 26, 2023
@tscrim tscrim deleted the root_systems/fix_subtype-35987 branch December 28, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nthiery nthiery Awaiting requested review from nthiery

@anneschilling anneschilling Awaiting requested review from anneschilling

@fchapoton fchapoton Awaiting requested review from fchapoton

1 more reviewer

@darijgr darijgr darijgr approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: combinatorics t: bug
Projects
None yet
Milestone
sage-10.3
Development

Successfully merging this pull request may close these issues.

cartan subtype depends on interval
3 participants
@tscrim @darijgr @vbraun