Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Aug 4, 2023

Fixes #36033 (comment)

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 4, 2023

This is one I found

--- a/src/sage/dynamics/arithmetic_dynamics/wehlerK3.py
+++ b/src/sage/dynamics/arithmetic_dynamics/wehlerK3.py
@@ -474,7 +474,7 @@ class WehlerK3Surface_ring(AlgebraicScheme_subscheme_product_projective):
            sage: Z = x0^2*y0^2 + 3*x0*x1*y0^2 + x1^2*y0^2 + 4*x0^2*y0*y1 + 3*x0*x1*y0*y1 \
            - 2*x2^2*y0*y1 - x0^2*y1^2 + 2*x1^2*y1^2 - x0*x2*y1^2 - 4*x1*x2*y1^2 \
            + 5*x0*x2*y0*y2 \
-           - 4*x1*x2*y0*y2 + 7*x0^2*y1*y2 + 4*x1^2*y1*y2 + x0*x1*y2^2 + 3*x2^2*y2^2 \
+           - 4*x1*x2*y0*y2 + 7*x0^2*y1*y2 + 4*x1^2*y1*y2 + x0*x1*y2^2 + 3*x2^2*y2^2
            sage: Y = x0*y0 + x1*y1 + x2*y2
            sage: X = WehlerK3Surface([Z, Y])
            sage: T = PP(1, 1, 0, 1, 0, 0)

The other one was in expression.pyx, which you already fixed.

@@ -732,8 +732,7 @@ def ToricCode(P,F):
sage: C.minimum_distance()
24
sage: C.minimum_distance(algorithm="guava") # optional - gap_packages (Guava package)
...
24
...24
sage: C = codes.ToricCode([[-2,-2],[-1,-2],[-1,-1],[-1,0],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ...?

I get just

sage:  C.minimum_distance(algorithm="guava")  
24

after installing guava.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess it accounts for sporadic output from GAP

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 5, 2023

We missed this one:

--- a/src/sage/tests/book_stein_ent.py
+++ b/src/sage/tests/book_stein_ent.py
@@ -21,10 +21,10 @@ sage: factor(2007)
 sage: factor(31415926535898)
 2 * 3 * 53 * 73 * 2531 * 534697
 sage: n = 7403756347956171282804679609742957314259318888\
-...9231289084936232638972765034028266276891996419625117\
-...8439958943305021275853701189680982867331732731089309\
-...0055250511687706329907239638078671008609696253793465\
-...0563796359
+....: 9231289084936232638972765034028266276891996419625117\
+....: 8439958943305021275853701189680982867331732731089309\
+....: 0055250511687706329907239638078671008609696253793465\
+....: 0563796359
 sage: len(n.str(2))
 704
 sage: len(n.str(10))

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2023

Thanks!

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

SageMath version 10.1.beta9, Release Date: 2023-08-05
@vbraun
Copy link
Member

vbraun commented Aug 8, 2023

Merge conflict

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 11, 2023

Merged with #36025 to resolve merge conflict.

@github-actions
Copy link

Documentation preview for this PR (built with commit 669065a; changes) is ready! 🎉

@vbraun vbraun merged commit 5340692 into sagemath:develop Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants