Skip to content

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Aug 2, 2023

G was renamed to g in 3 places in docs of CossidentePenttilaGraph

Here we rename these back

G was renamed to g in 3 places in docs of CossidentePenttilaGraph
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Documentation preview for this PR (built with commit 767fc2c; changes) is ready! 🎉

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks.

@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 2, 2023

Sorry for the accidental vandalism

@vbraun vbraun merged commit 8b23b9d into sagemath:develop Aug 5, 2023
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 11, 2023
sagemathgh-36025: Use `# optional - gap_package_grape` etc. instead of `# optional - gap_packages`
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
The Sage distribution has an optional SPKG `gap_packages`, which is a
collection of GAP packages used by parts of Sage.
The doctests that uses these packages are currently marked `# optional -
gap_packages`. Here we switch to using more specific feature tags. These
more specific features are tested dynamically, which works outside of
the Sage distribution.
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36017
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36025
Reported by: Matthias Köppe
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 12, 2023
sagemathgh-36025: Use `# optional - gap_package_grape` etc. instead of `# optional - gap_packages`
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
The Sage distribution has an optional SPKG `gap_packages`, which is a
collection of GAP packages used by parts of Sage.
The doctests that uses these packages are currently marked `# optional -
gap_packages`. Here we switch to using more specific feature tags. These
more specific features are tested dynamically, which works outside of
the Sage distribution.
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#36017
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36025
Reported by: Matthias Köppe
Reviewer(s): David Coudert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants