Skip to content

minor cleanup in binary quadratic forms over ZZ #36007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2023
Merged

minor cleanup in binary quadratic forms over ZZ #36007

merged 1 commit into from
Aug 5, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jul 31, 2023 •
edited
Loading

This makes a few pep8 corrections in the modified file. Also removes one type comparison.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit f1b9e57; changes) is ready! 🎉

kwankyu
kwankyu approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit c4b3f0d into sagemath:develop Aug 5, 2023
@fchapoton fchapoton deleted the cleanup_binary_quadform branch August 6, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees
No one assigned
Labels
c: quadratic forms t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @kwankyu @vbraun @mkoeppe