Skip to content

partial cython-lint cleanup in mod_sym_num #36002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2023
Merged

partial cython-lint cleanup in mod_sym_num #36002

merged 1 commit into from
Aug 5, 2023

Conversation

fchapoton
Copy link
Contributor

partial cleanup of the modified file, mostly caring for unused variables

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit 3fe2f17; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Test failures are unrelated (fixed in #36016)

@vbraun vbraun merged commit 859f6ca into sagemath:develop Aug 5, 2023
@fchapoton fchapoton deleted the cylint-mod-sym-num branch August 6, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: elliptic curves t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun