Fix typo in docstring #36062
Merged
Fix typo in docstring #36062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I look at the documentation preview at the link here, I see the old wrong docstring and not the corrected one. That does not seem right to me |
|
Yes, that is OK -- but not the similar docstring at the top of that page! I found that place in the source file and will update the PR. |
dcoudert
approved these changes
Aug 10, 2023
|
Documentation preview for this PR (built with commit 1b1f336; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2023
This corrects a typo in a docstring concerning subgroups of the modular group. The typo made a definition mathematically incorrect. See issue sagemath#36058 - [x ] The title is concise, informative, and self-explanatory. - [ x] The description explains in detail what this PR is about. - [ x] I have linked a relevant issue or discussion. - [ x] I have updated the documentation accordingly. ### ⌛ Dependencies No dependencies: based on 10.1.beta9 URL: sagemath#36062 Reported by: John Cremona Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a typo in a docstring concerning subgroups of the modular group. The typo made a definition mathematically incorrect.
Fixes #36058
⌛ Dependencies
No dependencies: based on 10.1.beta9