Skip to content

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Aug 6, 2023

Since 10.1.beta9, a doctest is failing in sage/graphs/bliss.pyx due to some changes in sage/groups/perm_gps/permgroup.py. One of them is that method .gens() now returns a tuple and no longer a list.

        sage: # optional - bliss
        sage: from sage.graphs.bliss import automorphism_group
        sage: alpha = "abcdefghijklmnopqrstuvwxyz"
        sage: G = Graph()
        sage: G.add_edges((alpha[i],alpha[j],"A") for i in range(0, 2) for j in range(14,20))
        sage: G.add_edges((alpha[i],alpha[j],"B") for i in range(2, 5) for j in range(14,20))
        sage: G.add_edges((alpha[i],alpha[j],"C") for i in range(5, 9) for j in range(14,20))
        sage: G.add_edges((alpha[i],alpha[j],"D") for i in range(9,14) for j in range(14,20))
        sage: A = automorphism_group(G)
        sage: print(A.gens())
Failed example:
    print(A.gens())
Expected:
    [('r','t'), ('s','r'), ('p','s'), ('q','p'), ('o','q'), ('l','n'),
     ('m','l'), ('j','m'), ('k','j'), ('i','h'), ('f','i'), ('g','f'),
     ('e','d'), ('c','e'), ('a','b')]
Got:
    (('m','n'), ('l','m'), ('k','l'), ('j','k'), ('h','i'), ('g','h'), ('f','g'), ('d','e'), ('c','d'), ('s','t'), ('r','s'), ('q','r'), ('p','q'), ('o','p'), ('a','b'))

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, feu vert

@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Documentation preview for this PR (built with commit ae7a1ce; changes) is ready! 🎉

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 11, 2023
sagemathgh-36040: Fix failing doctest in sage/graphs/bliss.pyx
    
Since 10.1.beta9, a doctest is failing in `sage/graphs/bliss.pyx` due to
some changes in `sage/groups/perm_gps/permgroup.py`. One of them is that
method `.gens()` now returns a tuple and no longer a list.

```py
        sage: # optional - bliss
        sage: from sage.graphs.bliss import automorphism_group
        sage: alpha = "abcdefghijklmnopqrstuvwxyz"
        sage: G = Graph()
        sage: G.add_edges((alpha[i],alpha[j],"A") for i in range(0, 2)
for j in range(14,20))
        sage: G.add_edges((alpha[i],alpha[j],"B") for i in range(2, 5)
for j in range(14,20))
        sage: G.add_edges((alpha[i],alpha[j],"C") for i in range(5, 9)
for j in range(14,20))
        sage: G.add_edges((alpha[i],alpha[j],"D") for i in range(9,14)
for j in range(14,20))
        sage: A = automorphism_group(G)
        sage: print(A.gens())
```

```py
Failed example:
    print(A.gens())
Expected:
    [('r','t'), ('s','r'), ('p','s'), ('q','p'), ('o','q'), ('l','n'),
     ('m','l'), ('j','m'), ('k','j'), ('i','h'), ('f','i'), ('g','f'),
     ('e','d'), ('c','e'), ('a','b')]
Got:
    (('m','n'), ('l','m'), ('k','l'), ('j','k'), ('h','i'), ('g','h'),
('f','g'), ('d','e'), ('c','d'), ('s','t'), ('r','s'), ('q','r'),
('p','q'), ('o','p'), ('a','b'))
```


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36040
Reported by: David Coudert
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 11751dc into sagemath:develop Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants