Skip to content

fix some pep8 in symbolic folder #35910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2023
Merged

fix some pep8 in symbolic folder #35910

merged 1 commit into from
Jul 9, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jul 6, 2023 •
edited
Loading

📚 Description

fixes some pycodestyle warnings in the symbolic folder.

also a few details in the code ;

in particular removing a workaround in the subrings of symbolic ring (#19231 )

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Documentation preview for this PR (built with commit d7904e3; changes) is ready! 🎉

mkoeppe
mkoeppe reviewed Jul 7, 2023
View reviewed changes
@vbraun vbraun merged commit eec0b62 into sagemath:develop Jul 9, 2023
@fchapoton fchapoton deleted the pep8_in_symbolic branch July 9, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: symbolics t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun