Add parameter key to methods multiple_edges and edge_boundary #35903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimpase
approved these changes
Jul 19, 2023
|
Thank you. |
|
Merge conflict |
|
I don't see any conflict with 10.1.beta7, so I set this ticket back to positive review. |
|
I'd suggest to rebase over beta7, just to be sure |
|
It's what I did using the button on the GitHub interface. |
|
please wait for the next beta |
|
Documentation preview for this PR (built with commit ee2084f; changes) is ready! 🎉 |
|
The failing doctests are independent from this PR. One of them is fixed in #36040. I'm setting this PR back to positive review. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2023
sagemathgh-35903: Add parameter key to methods multiple_edges and edge_boundary Part of sagemath#35902. ### 📚 Description We add parameter `key` to methods `multiple_edges` and `edge_boundary`. This is useful when users manipulate graphs with edges of incomparable types. On the way, we avoid some calls to `multiple_edges` with `sort=True` in method `is_tree`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35903 Reported by: David Coudert Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #35902.
📚 Description
We add parameter
keyto methodsmultiple_edgesandedge_boundary. This is useful when users manipulate graphs with edges of incomparable types.On the way, we avoid some calls to
multiple_edgeswithsort=Truein methodis_tree.📝 Checklist
⌛ Dependencies