some improvements in sage/graphs/orientations.py #35981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
mkoeppe
reviewed
Aug 4, 2023
mkoeppe
reviewed
Aug 4, 2023
|
I am mostly away from the keyboard, until mid August, and then again till early September.
…On 4 August 2023 20:34:50 BST, "Matthias Köppe" ***@***.***> wrote:
@mkoeppe commented on this pull request.
Otherwise LGTM
--
Reply to this email directly or view it on GitHub:
#35981 (review)
You are receiving this because your review was requested.
Message ID: ***@***.***>
|
mkoeppe
approved these changes
Aug 5, 2023
|
Thank you. |
|
Documentation preview for this PR (built with commit 80fc1f3; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2023
sagemathgh-35981: some improvements in sage/graphs/orientations.py We do some improvements in file `src/sage/graphs/orientations.py` and in particular in method `strong_orientations_iterator`. The next step will be to move all methods related to orientations from `graph.py` to `orientations.py`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#35981 Reported by: David Coudert Reviewer(s): David Coudert, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do some improvements in file
src/sage/graphs/orientations.pyand in particular in methodstrong_orientations_iterator.The next step will be to move all methods related to orientations from
graph.pytoorientations.py.📝 Checklist
⌛ Dependencies