Adapt to new Singular sat API #35980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
How about mentioning this PR in the comment? |
|
Is it 4.2.3 or 4.3.2? |
Right, thanks |
|
Would you also fix the PR description? That is where I got confused. |
kwankyu
reviewed
Aug 2, 2023
|
Documentation preview for this PR (built with commit 535b63a; changes) is ready! 🎉 |
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
satfunction that returns the saturation exponent was renamed tosat_with_expin [1]This patch makes Sage work with singular < 4.3.2p3 and > 4.3.2p4. With 4.3.2p3 and 4.3.2p4 it returns a wrong exponent [2], unless singular is patched with the above commit.
[1] Singular/Singular@3f7e01a
[2] Singular/Singular#1181