Skip to content

refresh descent_two_isogeny.pyx #35979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2023
Merged

refresh descent_two_isogeny.pyx #35979

merged 2 commits into from
Aug 5, 2023

Conversation

fchapoton
Copy link
Contributor

mostly pep8 formatting for the code

also removing 3 unused variables found by cython-lint

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

dcoudert
dcoudert suggested changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few remarks.

@fchapoton
Update descent_two_isogeny.pyx
c8114d8 
minor details as suggested
@fchapoton
Copy link
Contributor Author

ok, c'est fait. merci

@github-actions
Copy link

Documentation preview for this PR (built with commit c8114d8; changes) is ready! 🎉

dcoudert
dcoudert approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit f12752d into sagemath:develop Aug 5, 2023
@fchapoton fchapoton deleted the refresh_descent_two_isogeny branch August 6, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: elliptic curves t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe