Skip to content

some details in dirichlet.py #35959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2023
Merged

some details in dirichlet.py #35959

merged 3 commits into from
Aug 5, 2023

Conversation

fchapoton
Copy link
Contributor

Just a few minor changes in the modified file. Notably using the faster factorial and binomial

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton fchapoton force-pushed the some_details_in_dirichlet branch from b502592 to 38fafc1 Compare July 16, 2023 07:49
@fchapoton fchapoton force-pushed the some_details_in_dirichlet branch from e4fe991 to 43f9419 Compare July 16, 2023 10:04
tscrim
tscrim approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun
Copy link
Member

vbraun commented Jul 23, 2023

Merge conflict

@github-actions
Copy link

Documentation preview for this PR (built with commit 464df29; changes) is ready! 🎉

@vbraun vbraun merged commit 3205f9d into sagemath:develop Aug 5, 2023
@fchapoton fchapoton deleted the some_details_in_dirichlet branch August 6, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: number theory
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @vbraun @tscrim @mkoeppe