-
-
Notifications
You must be signed in to change notification settings - Fork 655
invariants are now linearly independent #35899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the linter is not happy, please fix that |
doctests are not passing |
642d26d
to
4bdf675
Compare
Documentation preview for this PR (built with commit 4bdf675; changes) is ready! 🎉 |
I must say that I feel ignored. What happened to #35684 (comment) ? The code doesn't even comply with the sage conventions. Most importantly, it is not at all clear (at least to me) why this check does the right thing. |
@mantepse - this PR was opened 2 weeks ago. There was ample time to propose improvements |
the invariants in a given degree are generated by the images of the monomials in this degree under the Reynolds operator |
And so I did - apparently even before the PR was opened. Should I have repeated my comment? |
Apologies, I thought that our mighty linters would complain about lines being too long. Unfortunately this hasn't happen, As to the correctness question, it's IMHO too basic to be added to the docs. |
this certainly would have helped. Anyhow, feel free to open another PR to fix whatever you think needs to be fixed. |
I think that also 'len(x) == 0' is not according to the style guide.
The code was fixed already at least twice, without comment, so I doubt that it is too basic. |
fixes #35684
please read issue for more information