Skip to content

Conversation

Bruno-TT
Copy link
Contributor

@Bruno-TT Bruno-TT commented Jul 4, 2023

fixes #35684

please read issue for more information

@fchapoton
Copy link
Contributor

the linter is not happy, please fix that

@fchapoton
Copy link
Contributor

doctests are not passing

@dimpase dimpase force-pushed the invariants_of_degree_fix branch from 642d26d to 4bdf675 Compare July 11, 2023 11:04
@github-actions
Copy link

Documentation preview for this PR (built with commit 4bdf675; changes) is ready! 🎉

@vbraun vbraun merged commit e237c66 into sagemath:develop Jul 20, 2023
@mantepse
Copy link
Contributor

I must say that I feel ignored. What happened to #35684 (comment) ?

The code doesn't even comply with the sage conventions. Most importantly, it is not at all clear (at least to me) why this check does the right thing.

@dimpase
Copy link
Member

dimpase commented Jul 21, 2023

@mantepse - this PR was opened 2 weeks ago. There was ample time to propose improvements

@dimpase
Copy link
Member

dimpase commented Jul 21, 2023

Most importantly, it is not at all clear (at least to me) why this check does the right thing.

the invariants in a given degree are generated by the images of the monomials in this degree under the Reynolds operator $\rho$. The fix just keeps adding linearly independent images of mononials under $\rho$, until there are no more to add.
Actually, it can be sped up by using available info on the invariant ring - e.g. the dimension in this degree may be known in advance, e.g. from the Molien series.
@Bruno-TT - can you look at it?

@mantepse
Copy link
Contributor

@mantepse - this PR was opened 2 weeks ago. There was ample time to propose improvements

And so I did - apparently even before the PR was opened. Should I have repeated my comment?

@dimpase
Copy link
Member

dimpase commented Jul 21, 2023

Apologies, I thought that our mighty linters would complain about lines being too long. Unfortunately this hasn't happen,
and the 147-chars line just went in...

As to the correctness question, it's IMHO too basic to be added to the docs.

@dimpase dimpase changed the title invariants are now (probably) linearly independent invariants are now linearly independent Jul 21, 2023
@dimpase
Copy link
Member

dimpase commented Jul 21, 2023

Should I have repeated my comment?

this certainly would have helped. Anyhow, feel free to open another PR to fix whatever you think needs to be fixed.

@mantepse
Copy link
Contributor

mantepse commented Jul 21, 2023

Apologies, I thought that our mighty linters would complain about lines being too long. Unfortunately this hasn't happen, and the 147-chars line just went in...

I think that also 'len(x) == 0' is not according to the style guide.

As to the correctness question, it's IMHO too basic to be added to the docs.

The code was fixed already at least twice, without comment, so I doubt that it is too basic.

@Bruno-TT Bruno-TT deleted the invariants_of_degree_fix branch August 22, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FinitelyGeneratedMatrixGroup_gap.invariants_of_degree should return a basis of the space of invariants
7 participants