sage.groups.perm_gps.partn_ref*: Modularization fixes
#35881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 24, 2023 20:08
…pport code, avoid use of FLINT
dcoudert
suggested changes
Jul 25, 2023
| """ | ||
| cdef int i = 0, j = 0, location = 0, n = PS.degree | ||
| bitset_zero(b) | ||
| while 1: |
There was a problem hiding this comment.
while True might be better.
Furthermore, this loop has no control on the max value of I . Isn't it safer to use a for loop combined with a else statement to raise an error in case break is never called ?
There was a problem hiding this comment.
I've made these (and other) style fixes.
I also tested with an assert i < PS.degree at the end of the while loops and ran the tests for the faulty random seed reported in https://groups.google.com/g/sage-release/c/4mtUN8Rz92o/m/FLXKh321BgAJ; the assertion held, so at least this is not related.
I don't think I want to put the assertion there permanently though
|
Documentation preview for this PR (built with commit 526efac; changes) is ready! 🎉 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
partn_ref2depends onsage.libs.gap.We restore the independence of
partn_reffromsage.libs.gapby creating a separate function for the case ofPS_first_smallestwith non-Nonepartn_ref_alginpartn_ref2.We also remove the compile-time dependency on flint.
📝 Checklist
⌛ Dependencies