Skip to content

Implementing moment angle complexes #35875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 72 commits into from
Sep 16, 2023
Merged

Implementing moment angle complexes #35875

merged 72 commits into from
Sep 16, 2023

Conversation

OP5642
Copy link
Contributor

@OP5642 OP5642 commented Jul 2, 2023 •
edited by fchapoton
Loading

Description

This is a part of #35640 (GSoC 2023).

Implementing moment-angle complexes, one of the key constructions in toric topology. Many methods are yet to be implemented, which will be closely related to the simplicial complex over which the moment-angle complex is constructed.

Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Dependencies

@OP5642
Copy link
Contributor Author

OP5642 commented Jul 2, 2023

Currently trying out whether cubical complexes might be better for the construction of _moment_angle_complex attribute. @tscrim, it seems to me that it is quite a bit faster and we can avoid a lot of unnecessary code that way.

OP5642 added 20 commits July 4, 2023 04:45
@OP5642
More work on the trivial_massey_product method
a79e769
@OP5642
Minor changes to the docstring
7f13f84
@OP5642
Added components() method and updated docstrings
28ac99a
@OP5642
Changes to the components() method
eb82c9c
@OP5642
Merge branch 'non_golod_complexes' into moment_angle_complexes
e9c2602
@OP5642
Started working on golod_decomposition() method
0df6317
@OP5642
Minor changes
a689134
@OP5642
Initial work on implementing cohomology()
b259a00
@OP5642
Significant improvements to the homology() method
c022aa7
@OP5642
Fixed homology() method and added betti() method
81def2f
@OP5642
Minor improvements to the trivial_massey_product() method
1025138
@OP5642
Added euler_characteristic() method
db561f5
@OP5642
Removed the create_complex parameter in the constructor
1f83040
@OP5642
Added product() method
85b9e56
@OP5642
Made MomentAngleComplex inherit UniqueRepresentation
5f8b229
@OP5642
Fixed __classcall_private__() method
af70dbd
@OP5642
Minor improvements to the documentation
3566e7e
@OP5642
Minor improvements to the constructor
99df72b
@OP5642
Improvements to the homology_groups() method
fd1f435
@OP5642
Minor changes to the comments
4ae0e24
@OP5642 OP5642 marked this pull request as ready for review August 22, 2023 06:23
@OP5642 OP5642 mentioned this pull request Aug 31, 2023
Merged
5 tasks
tscrim
tscrim requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the docstrings themselves, it would be good to try to get many of the lines less that 80 chars/line. Perhaps most of them are (I can't immediately check on the web interface), but it seems like many of them are over.

This was referenced Sep 8, 2023
Open
Open
Open
Closed
@OP5642
Copy link
Contributor Author

OP5642 commented Sep 8, 2023

A lot of them were definitely over 80 chars/line, thank you. I think I managed to break most of them (apart from one LaTeX line at the beginning of the class-level doc), although many of them within the EXAMPLES blocks are still over 80 (because the representation is rather long). Should I break these lines as well (although I have noticed that this seems to be considered acceptable in some other modules)?

@tscrim
Copy link
Collaborator

tscrim commented Sep 9, 2023

A lot of them were definitely over 80 chars/line, thank you. I think I managed to break most of them (apart from one LaTeX line at the beginning of the class-level doc), although many of them within the EXAMPLES blocks are still over 80 (because the representation is rather long). Should I break these lines as well (although I have noticed that this seems to be considered acceptable in some other modules)?

You can break latex (or any other formatting thing) over multiple lines.

Also, instead of \dotso, please use \cdots and \ldots as appropriate (in a paper, I would go with \dotso, but its better to try to use more basic latex).

This was referenced Sep 9, 2023
Open
Open
tscrim
tscrim requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some last little things.

OP5642 and others added 2 commits September 14, 2023 19:03
@OP5642 @tscrim
Apply suggestions from code review
50a7db5 
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
@OP5642
Improved the documentation
80bf983
@github-actions
Copy link

Documentation preview for this PR (built with commit 80bf983; changes) is ready! 🎉

tscrim
tscrim approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@tscrim tscrim added this to the sage-10.2 milestone Sep 15, 2023
@vbraun vbraun merged commit 23b1a0a into sagemath:develop Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: algebraic topology t: enhancement
Projects
None yet
Milestone
sage-10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@OP5642 @tscrim @vbraun