Skip to content

deprecate some imports #35841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 20, 2023
Merged

deprecate some imports #35841

merged 5 commits into from
Jul 20, 2023

Conversation

jhpalmieri
Copy link
Member

  • Head toward deprecation of automatic imports of some dev tools
  • Remove unnecessary assignments in tests/benchmark.py

Deprecate the imports of some dev tools

📚 Description

This is a branch to address #34259, replacing the old trac branch. It doesn't make all of the original changes: the original branch. In particular, the original branch added a bunch of lines like from sage.misc.misc import cputime even though the import of cputime was not changes, just in case someone wanted to change it later. I skipped all of those additions. The original branch made a few other changes that were not connected to the purposes of this pull request (e.g. the changes to src/sage/combinat/composition.py), and I skipped those, too.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@jhpalmieri jhpalmieri mentioned this pull request Jun 26, 2023
Closed
@github-actions
Copy link

Documentation preview for this PR (built with commit 463e360; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for narrowing this ticket, which made it easier to review.

@jhpalmieri
Copy link
Member Author

Thank you!

@vbraun
Copy link
Member

vbraun commented Jul 8, 2023

Tests fail after merging 10.1.beta5

@jhpalmieri
Copy link
Member Author

I think that should fix it. (Among the original changes: replacing from sage.all import * with specific imports, including imports of cputime and walltime. When combined with #35816, this led to a deprecation warning and hence a doctest failure.)

@vbraun vbraun merged commit 04f9e45 into sagemath:develop Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@jhpalmieri @vbraun @mkoeppe @kwankyu