Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 7, 2023

📚 Description

docker.yml still had some steps (used by upstream projects that use this reusable workflow) that referred to Trac. As we have taken down Trac, upstream ci-sage workflows would fail (see scipopt/SCIP-SDP#4 (comment))
We remove these steps now.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

Documentation preview for this PR (built with commit ce38828) is ready! 🎉

@fchapoton
Copy link
Contributor

so, no need to replace these steps by anything ?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 13, 2023

I may or may not build a similar feature using GitHub PRs, but making that available is not urgent

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, well, then

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 13, 2023

Thanks!

@vbraun vbraun merged commit 81075d6 into sagemath:develop Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants