gap: use CALL_WITH_STREAM to redirect output to string #35735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids use of deeply internal GAP APIs which may change at any time. In particular `TypOutputFile` is likely to change again and again. In contrast, `CALL_WITH_STREAM` is on a much higher level (and even reachable from the GAP language itself). We have no plans to change it.
27f394f to
8bcf6e3
Compare
|
Documentation preview for this PR (built with commit 8bcf6e3) is ready! 🎉 |
fchapoton
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This avoids use of deeply internal GAP APIs which may change at any time. In particular
TypOutputFileis likely to change again and again.In contrast,
CALL_WITH_STREAMis on a much higher level (and even reachable from the GAP language itself). We have no plans to change it.Together with PR #35702 this resolves #35361.
📝 Checklist
⌛ Dependencies