little refreshment of code in Weyl groups #35730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Jun 5, 2023
fingolfin
reviewed
Jun 5, 2023
tscrim
requested changes
Jun 10, 2023
There was a problem hiding this comment.
Just a few little things. Once changed and if no objections from @fingolfin, then we can set this to a positive review I think.
|
Documentation preview for this PR (built with commit 0d78193) is ready! 🎉 |
tscrim
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Thank you. LGTM.
If @fingolfin has any objections, we can revert the positive review.
|
Arigato, Travis |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Some minor code details in the file
weyl_groups.pyalso fixing #35508
📝 Checklist
⌛ Dependencies