provide matrix_symbolic_sparse class #35714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mkoeppe
reviewed
Jun 3, 2023
This is needed in particulat to specialize echelonize(), cf sagemath#35653
without it, simplify_full() and canonicalize_radical() do not work also fixed docs by adding few */modules/*sparse* missing in the index
2bfd3ba to
128c137
Compare
|
Documentation preview for this PR (built with commit 3eadc12) is ready! 🎉 |
|
Likely unrelated, but what's going on with the segfaults in libgap? https://github.com/sagemath/sage/actions/runs/5169419889/jobs/9311663557?pr=35714#step:11:5214 |
the previous round of tests didn't show these errors. So it's probably random noise. |
|
ok then |
|
in case, I tried to reproduce the libgap segfault using the same random seed, no luck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sparse matrices over SR are broken without this
This is needed in particular to specialize echelonize(), cf #35653