Skip to content

Fix corner case of ordered set partitions iteration #35700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2023
Merged

Fix corner case of ordered set partitions iteration #35700

merged 1 commit into from
Jun 3, 2023

Conversation

videlec
Copy link
Contributor

@videlec videlec commented May 31, 2023

📚 Description

The function multiset_permutation_next_lex was wrong on empty input and is fixed in this PR.

Fixes #35654

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@videlec videlec requested a review from fchapoton May 31, 2023 10:57
@github-actions
Copy link

Documentation preview for this PR (built with commit 909f767) is ready! 🎉

fchapoton
fchapoton approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok if all tests and linter check pass

@vbraun vbraun merged commit bc6d3bd into sagemath:develop Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

OrderedSetPartitions() fails for the empty set
4 participants
@videlec @fchapoton @vbraun @mkoeppe