Skip to content

cleaning some things remaining from python 2 #35792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2023
Merged

cleaning some things remaining from python 2 #35792

merged 1 commit into from
Jul 1, 2023

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Jun 18, 2023 •
edited
Loading

📚 Description

this is making some little changes, both in code and doc, related to the transition py2 to py3

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton fchapoton force-pushed the cleaning_some_py2_things branch from 78a8fc4 to 9f4a294 Compare June 18, 2023 12:08
@github-actions
Copy link

Documentation preview for this PR (built with commit 9f4a294) is ready! 🎉

mkoeppe
mkoeppe approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 41d8113 into sagemath:develop Jul 1, 2023
@fchapoton fchapoton deleted the cleaning_some_py2_things branch July 2, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun