cylint: remove some unused variables in rings/ #35770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 390cc58) is ready! 🎉 |
mkoeppe
reviewed
Jun 14, 2023
|
|
||
| s = f[n] | ||
| for i from n > i >= 0: | ||
| s = s*x+f[i] | ||
| s = s * x + f[i] |
There was a problem hiding this comment.
shouldn't this be s*x + f[i]?
There was a problem hiding this comment.
I do no think so. Can we please move forward ?
There was a problem hiding this comment.
https://peps.python.org/pep-0008/#other-recommendations
"If operators with different priorities are used, consider adding whitespace around the operators with the lowest priority(ies)."
mkoeppe
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
remove some of the many unused variables in pyx files in the
ringsfolder, found usingcython-lint📝 Checklist
⌛ Dependencies