fix most E301 warnings #35768
Merged
fix most E301 warnings #35768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcoudert
suggested changes
Jun 14, 2023
| @@ -964,19 +963,22 @@ def sum_by_coefficients_with(self, right): | |||
| # raise TypeError, "Oh no! The multiplier cannot be coerced into the base ring of the quadratic form. =(" | |||
| # | |||
| # return QuadraticForm(self.base_ring(), self.dim(), [c * self.__coeffs[i] for i in range(len(self.__coeffs))]) | |||
| # ========================================================================================================================= | |||
There was a problem hiding this comment.
I don't understand this change in view of the bloc of commented code.
| coercible to the base ring of the quadratic form. If a vector | ||
| coercible to the base ring of the quadratic form. | ||
|
|
||
| If a vector |
There was a problem hiding this comment.
You could align this bloc in 80 columns mode
| @@ -6643,6 +6643,7 @@ def reduction_at(p): | |||
| return (H_q) | |||
| #<------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Isn't it a problem to let this line without space after # ?
| @@ -6727,6 +6728,7 @@ def test_with_T(R): | |||
| return xs | |||
| #<------------------------------------------------------------------------- | |||
|
Documentation preview for this PR (built with commit dce64d6) is ready! 🎉 |
|
Merci beaucoup, David. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This fixes most E301 warnings, except 2 problematic ones relating to strange new syntax for code typing
📝 Checklist
⌛ Dependencies