Skip to content

gap: adapt get_global to use official libgap API #35760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 21, 2023
Merged

gap: adapt get_global to use official libgap API #35760

merged 6 commits into from
Jun 21, 2023

Conversation

fingolfin
Copy link
Contributor

No description provided.

@fchapoton
Copy link
Contributor

well, does not compile

@fchapoton
Copy link
Contributor

I guess GAP_ValueGlobalVariable should be added to the appropriate .pxd file ?

@fingolfin
Copy link
Contributor Author

Huh, GAP_ValueGlobalVariable is already in gap_includes.pxd, and in fact is already being used in element.pyx and util.pyx. Both of these, as well as libgap.pyx (which this PR modifies) also do this:

from .gap_includes cimport *

So I have no idea what the problem is, I am afraid -- my Python / Cython knowledge is just too limited :-(

@fingolfin
Copy link
Contributor Author

It took me some time to find a job which did not fail for other reasons, but now I see this is the error:

    Error compiling Cython file:
    ------------------------------------------------------------
    ...
                sage: libgap.get_global('FooBar')
                Traceback (most recent call last):
                ...
                GAPError: Error, VAL_GVAR: No value bound to FooBar
            """
            return GAP_ValueGlobalVariable(variable)
                                         ^
    ------------------------------------------------------------

    sage/libs/gap/libgap.pyx:542:38: Cannot convert 'Obj' to Python object
    Traceback (most recent call last):
      File "/usr/local/miniconda/envs/sage-build/lib/python3.11/site-packages/Cython/Build/Dependencies.py", line 1262, in cythonize_one_helper
        return cythonize_one(*m)
               ^^^^^^^^^^^^^^^^^
      File "/usr/local/miniconda/envs/sage-build/lib/python3.11/site-packages/Cython/Build/Dependencies.py", line 1238, in cythonize_one

So I guess that means GAP_ValueGlobalVariable is fine, but there needs to be some conversion/wrapping/unwrapping for the argument or the return value?

fchapoton
fchapoton reviewed Jun 14, 2023
View reviewed changes
@fchapoton
Copy link
Contributor

fchapoton commented Jun 14, 2023 •
edited
Loading

now complains about

        return make_any_gap_element(self, GAP_ValueGlobalVariable(variable.value))
    AttributeError: 'str' object has no attribute 'value'

so maybe the .value is not needed ?

@fchapoton
Update libgap.pyx
a5928fd 
trying without .value
@fchapoton
Copy link
Contributor

Now

  File "sage/libs/gap/libgap.pyx", line 542, in sage.libs.gap.libgap.Gap.get_global
    return make_any_gap_element(self, GAP_ValueGlobalVariable(variable))
TypeError: expected bytes, str found

so we need to change the string to bytes. Using str_to_bytes ?

from sage.cpython.string cimport str_to_bytes

@fchapoton
Update libgap.pyx
2697eed 
adding str_to_bytes
@fingolfin
Copy link
Contributor Author

Using str_to_bytes sounds sensible. Thank you for your help.

@fchapoton
Copy link
Contributor

I have tested locally, and it seems to work.

@fchapoton
Copy link
Contributor

almost there.Should we just change the doctest results from a GAPError to NULL ?

@fingolfin
Copy link
Contributor Author

Fine by me

@fchapoton
Update libgap.pyx
7d97f68 
now returning NULL for undefined GAP variables, instead of raising GapError
@github-actions
Copy link

Documentation preview for this PR (built with commit 7d97f68) is ready! 🎉

@fchapoton
Copy link
Contributor

checks are ok. Shall I approve and set to positive ?

@fingolfin
Copy link
Contributor Author

Fine by me

fchapoton
fchapoton approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough, hopefully

@vbraun vbraun merged commit c32c4f0 into sagemath:develop Jun 21, 2023
@fingolfin fingolfin deleted the mh/get_global branch June 22, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: packages: standard
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fingolfin @fchapoton @vbraun @mkoeppe