Skip to content

Implementing the type B Ish arrangement. #35757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2023
Merged

Implementing the type B Ish arrangement. #35757

merged 2 commits into from
Jun 21, 2023

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Jun 13, 2023

We implement the type B Ish arrangement following a recent preprint by Tran and Tsujie arXiv: 2304.12022.

📚 Description

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tscrim tscrim added this to the sage-10.1 milestone Jun 13, 2023
@github-actions
Copy link

Documentation preview for this PR (built with commit 6a1d149) is ready! 🎉

fchapoton
fchapoton approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice little thing, indeed. Thanks for the addition.

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 13, 2023

Thank you.

@vbraun vbraun merged commit c55e716 into sagemath:develop Jun 21, 2023
@tscrim tscrim deleted the hyperplanes/type_B_ish branch July 5, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: geometry p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@tscrim @fchapoton @vbraun @mkoeppe