Support sympy 1.12 #35635
Support sympy 1.12 #35635
Conversation
|
Looks good to me. I'm not sure what is the right way to manage this in CI going forwards because sympy has this CI job that is based on trac but Sage has moved to GitHub: |
Thanks, I don't know how CI works. This PR is supposed to build and test sage, but nothing happened here... I build and tested sage in my with this patch applied, both with sympy 1.12 and with sympy 1.11.1. Someone else will have to make a PR to actually update sympy in sage to 1.12. My goal here is just to make tests pass with both versions of sympy so distros and sage-the-distro can update sympy without a flag day. Also since I hope this can actually be merged in 10.0, but actually updating sympy at this point in the release cycle is out of the question, I think, since testing and reviewing an update takes more time. |
|
I think that these changes are better way to write the doctests in any case. But I cannot currently test sympy 1.12. I could trust you on those. |
|
Works for me. I don't see the rush to get it in 10.0 though: no matter when 10.0 is released, in one or two weeks at most some dependency update will break tests again. |
gh-35662: Sympy 1.12 upgrade <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> https://github.com/sympy/sympy/wiki/release-notes-for-1.12 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies - Depends on #35635 <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35662 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
📚 Description
Sympy 1.12 has been released. This PR fixes 3 failing doctests in
sage.calculus.calculus.Tested with both 1.12 and 1.11.1.
📝 Checklist