Skip to content

Remove jupyter-packaging for conda #35627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2023
Merged

Remove jupyter-packaging for conda #35627

merged 3 commits into from
May 28, 2023

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented May 8, 2023 •
edited
Loading

📚 Description

We don't need jupyter-packaging (explicitly, maybe only some dependencies need it, depending on versions) so conda is able to build the dependency tree. Part of #34626. Moreover, its not working with the conda 3.11 test: https://github.com/sagemath/sage/actions/runs/4906896658/jobs/8761652608

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez
Remove jupyter-packaging for conda
923edb5 
We don't need jupyter-packaging (explicitly, maybe only some dependencies) so conda is able to handle the dependency tree. Part of sagemath#34626. Moreover, its not working with the conda 3.11 test: https://github.com/sagemath/sage/actions/runs/4906896658/jobs/8761652608
@tobiasdiez tobiasdiez added c: packages: standard s: run conda ci Run the conda workflow on this PR. labels May 8, 2023
@tobiasdiez tobiasdiez requested a review from mkoeppe May 8, 2023 04:42
@tobiasdiez tobiasdiez added s: run conda ci Run the conda workflow on this PR. and removed s: run conda ci Run the conda workflow on this PR. labels May 8, 2023
mkoeppe
mkoeppe approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, although the same applies also to other packages that are only build dependencies. For example added in #35593, hatch_*, and some from your list in #34626

@tobiasdiez
Copy link
Contributor Author

@mkoeppe Thanks for the review!

Concerning the word "build dependency", jupyter-packacking is not a build dependency of sagemath (lib), it's a build dependency of some versions of some dependencies, right? Then yes, all such transitive build dependencies can be removed from the conda env.

@mkoeppe
Copy link
Contributor

mkoeppe commented May 8, 2023

Yes, it's a build dependency of some jupyterlab components.

@mkoeppe
Copy link
Contributor

mkoeppe commented May 8, 2023

In fact, I'm hoping that we can get rid of jupyter-packaging (whose main function is to orchestrate javascript builds) from the Sage distribution itself, by switching all such packages from source packages to wheel packages.

@github-actions
Copy link

github-actions bot commented May 8, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 808069e

@vbraun vbraun merged commit 92c3735 into sagemath:develop May 28, 2023
@tobiasdiez tobiasdiez deleted the jupyterpack-conda branch May 28, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: packages: standard p: critical / 2 s: run conda ci Run the conda workflow on this PR.
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasdiez @mkoeppe @vbraun