Fix weak Popov form testing #35699
Merged
Fix weak Popov form testing #35699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mezzarobba
reviewed
Jul 2, 2023
| # leading positions should not have duplicates, which is equivalent to: | ||
| # once sorted, it doesn't contain a pair of equal successive entries | ||
| # (we do not sort if we want to test |
There was a problem hiding this comment.
I guess this line is a leftover from a previous version of the comment starting at line 1678 and should be removed? Lgtm otherwise.
There was a problem hiding this comment.
Yes, absolutely, thanks for spotting this.
|
Documentation preview for this PR (built with commit 648f21b; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
This fixes the test for weak Popov form for univariate polynomial matrices, that was wrong in some column-wise cases. This fixes issue #35698 . This adds some more comments in the code of the relevant method, to better highlight its correction.
📝 Checklist
⌛ Dependencies
None.