Skip to content

Conversation

miguelmarco
Copy link
Contributor

📚 Description

Addresses #35246

The lazy imported interfaces are not registered as magic modes. This patch registers them too.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • [] I have created tests covering the changes.
  • [] I have updated the documentation accordingly.

@miguelmarco
Copy link
Contributor Author

I just made the lazy imported interfaces be registered. Didn't check if this affects starting time.

@github-actions
Copy link

Documentation preview for this PR (built with commit 83c053c) is ready! 🎉

@jhpalmieri
Copy link
Member

This looks good to me. I ran ./sage --startuptime many times with and without this branch, and I don't see any measurable slowdown. As long as tests pass, let's merge it.

@jhpalmieri
Copy link
Member

(Assuming it's ready for review.)

@miguelmarco
Copy link
Contributor Author

It is.

@vbraun vbraun merged commit 15f8a33 into sagemath:develop Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants