Make BooleanPolynomial.variables() way faster #35510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
The implementation of
BooleanMonomialVariableIterator
is a bit slow. It is based in polybori'sPBMonomVarIter
which implements an iterator over the variables of a boolean monomial which is slow.However there is
PBMonomIter
which implements an iterator over the indices of the variables which seems to be faster; the variables can then be retrieved from the ring itself.This is what we do in this commit. Performance is way better.
I don't know why this difference, maybe because the variables are strings and this suffers from allocation, while indices are just 32 bit ints.
Before this commit:
After this commit:
Another example taken from a doctest for the method
PolynomialSequence_generic.connected_components()
insrc/sage/rings/polynomial/multi_polynomial_sequence.py
:Before this commit:
After this commit:
📝 Checklist