refactor: outsource methods in combinatorial polyhedron #35577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Apr 28, 2023
| @@ -3631,14 +3585,45 @@ cdef class CombinatorialPolyhedron(SageObject): | |||
| elif not do_edges and self._ridges is None: | |||
| raise ValueError('could not determine ridges') | |||
|
|
|||
| cdef bint _is_dual_faster_to_compute_edges_or_ridges(self, bint do_edges) except -1: | |||
There was a problem hiding this comment.
I would suggest to use a more general method name that returns an "algorithm name" instead of a boolean
There was a problem hiding this comment.
Good point.
Taken care of in e4ea210.
I think I optimized in all the right places. However, I also optimized in all the wrong places. Having testable methods with human-readable input and output seems better.
the method is called once per polyhedron, so speed does not matter here
|
Documentation preview for this PR is ready! 🎉 |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
The class
CombinatorialPolyhedronis clustered with way too long methods.We create two new methods, whose purpose can be understood by reading the name.
This refactoring is motivated by #34773. (Before I want to introduce more logic, I want to clean up a bit.)
📝 Checklist
⌛ Dependencies