Skip to content

simplify some trivial iterations #35576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2023
Merged

simplify some trivial iterations #35576

merged 2 commits into from
May 28, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

replace a lot of (x for x in something) by something, inside all, any, sum, etc

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 28, 2023 

sage -t --random-seed=325292134826394888144321814057003138306 sage/combinat/multiset_partition_into_sets_ordered.py  # 2 doctests failed
sage -t --random-seed=325292134826394888144321814057003138306 sage/matroids/matroid.pyx  # 1 doctest failed

@fchapoton fchapoton force-pushed the simplify_some_iterations branch from d7afa6d to 01eafa0 Compare April 28, 2023 18:32
@fchapoton fchapoton force-pushed the simplify_some_iterations branch from 01eafa0 to 369545c Compare April 29, 2023 09:27
dcoudert
dcoudert approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fchapoton
Copy link
Contributor Author

so may I set to positive review ?

@vbraun
Copy link
Member

vbraun commented May 22, 2023

Merge conflict

@github-actions
Copy link

Documentation preview for this PR (built with commit dd669cd) is ready! 🎉

@dcoudert
Copy link
Contributor

Do you plan to fix this issue in this ticket or is it done in another one ?

./sage/manifolds/differentiable/diff_form.py:785:84: W291 trailing whitespace
1       W291 trailing whitespace

@fchapoton
Copy link
Contributor Author

somebody broke the linter somewhere. I am bored about fixing other's mistakes. Not here, in any case.

@dcoudert
Copy link
Contributor

Agreed.

dcoudert
dcoudert approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit f5a86be into sagemath:develop May 28, 2023
@fchapoton fchapoton deleted the simplify_some_iterations branch July 16, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @mkoeppe @vbraun @dcoudert @kwankyu