Skip to content

some typing and code tweaks in MZV #35567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2023
Merged

some typing and code tweaks in MZV #35567

merged 4 commits into from
May 28, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

  • Add some basic typing annotations.
  • Try to gain speed by using _monomial method.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

mkoeppe
mkoeppe reviewed Apr 25, 2023
View reviewed changes
mkoeppe
mkoeppe reviewed Apr 25, 2023
View reviewed changes
@github-actions
Copy link

Documentation preview for this PR (built with commit e14e1a7) is ready! 🎉

@vbraun vbraun merged commit 39619d4 into sagemath:develop May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: algebraic geometry t: performance t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun