I have forgotten how to tell it where the new tarball eclib-20230424.tar.bz2 is on github.

I have forgotten how to tell it where the new tarball eclib-20230424.tar.bz2 is on github.

Dammit, the source is at https://github.com/JohnCremona/eclib/releases/download/v20230424/eclib-20230424.tar.bz2 but the upstream tarball line in checksums.ini has

https://github.com/JohnCremona/eclib/releases/download/VERSION/eclib-VERSION.tar.bz2

and the version has no v in front of it. Where is AI when you need it! I will edit checksums.ini accordingly.

The lint errors are fixed in #35552

The lint errors are fixed in #35552

I thought they would have fixed elsewhere but saw no harm in fixing them too so all my tests would pass. Is that a problem?

Most likely unproblematic

@isuruf @tobiasdiez I am running our conda integration test on this PR (triggered by the label "s: run conda ci"), and I see a failure in https://github.com/sagemath/sage/actions/runs/4789352499/jobs/8517110991?pr=35555:

Could not solve for environment specs
  The following packages are incompatible
  ├─ primecountpy   is installable with the potential options
  │  ├─ primecountpy 0.1.0 would require
  │  │  └─ python_abi 3.10.* *_cp310, which can be installed;
  │  ├─ primecountpy 0.1.0 would require
  │  │  └─ python_abi 3.7.* *_cp37m, which can be installed;
  │  ├─ primecountpy 0.1.0 would require
  │  │  └─ python_abi 3.8.* *_cp38, which can be installed;
  │  └─ primecountpy 0.1.0 would require
  │     └─ python_abi 3.9.* *_cp39, which can be installed;
  └─ python 3.11**  is uninstallable because it requires
     └─ python_abi 3.11.* *_cp311, which conflicts with any installable versions previously reported.

@mkoeppe, see conda-forge/primecountpy-feedstock#6

So only the conda-related tests fail?

I just merged the latest develop into the original PR branch.

The immediate failures for anything labeled "conda ... environment-optional" are unrelated and can be ignored

Documentation preview for this PR is ready! 🎉
Built with commit: 5f14b39

I've tested it using tox -e docker-fedora-38-standard-incremental -- eclib and docker-ubuntu-focal-standard-incremental -- eclib, builds fine.

Setting as blocker since this is needed for the conda workflows (otherwise conda-installed eclib is rejected). Is is a good idea to set a fixed eclib version in the conda.txt file?

Setting as blocker since this is needed for the conda workflows (otherwise conda-installed eclib is rejected). Is is a good idea to set a fixed eclib version in the conda.txt file?

Maybe, I don't know. None of the other distros/*.txt mention a version.