Skip to content

Conversation

dwbump
Copy link
Contributor

@dwbump dwbump commented Apr 22, 2023

📚 Description

This is a review PR for #35540.

(1) It adds a test in the centralizer method in GroupMixinLibGAP.
(2) It changes a variable name centralizer -> centralizer_gens in the centralizer method
(3) It adds the group_id method in GroupMixinLibGAP.

For (2), the variable does not represent the centralizer, but a set of generators.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • [x ] I have updated the documentation accordingly.

⌛ Dependencies

#35540: This is a review PR for that #35540.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 61f881e

@vbraun vbraun merged commit 04f39ad into sagemath:develop May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants