Cleaning set partition #35543
Merged
Cleaning set partition #35543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Apr 19, 2023
src/sage/combinat/set_partition.py
Outdated
| for opt in kwargs: | ||
| self._latex_options[opt] = kwargs[opt] | ||
| for opt, value in kwargs.items(): | ||
| self._latex_options[opt] = value |
There was a problem hiding this comment.
is this not just self._latex_options.update(kwargs)?
|
Branch seems to be on top of #35542? |
1f0f95b to
71e509a
Compare
|
Documentation preview for this PR is ready! 🎉 |
mkoeppe
approved these changes
Apr 20, 2023
mantepse
reviewed
Apr 21, 2023
| @@ -3197,7 +3172,7 @@ def cardinality(self): | |||
| sage: stirling_number2(5,3) | |||
| 25 | |||
| """ | |||
| return stirling_number2(len(self._set), self._k) | |||
| return stirling2(len(self._set), self._k) | |||
There was a problem hiding this comment.
why is that better than stirling_number2?
|
In case you have time: #29996 is, for me, a serious problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Various details and tweaks in the code and doc of
set_partition.pyin order to reach full pep8 and better pylint compliance
📝 Checklist
⌛ Dependencies