Skip to content

Conversation

tornaria
Copy link
Contributor

@tornaria tornaria commented Apr 4, 2023

These happen with python 3.11, setuptools 67.6.1, numpy 1.24.2. When pythran 0.12.1 is installed, I get 24 doctest failures due to deprecation warnings; they are all gone with this commit.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • Current tests cover the changes.

These happen with python 3.11, setuptools 67.6.1, numpy 1.24.2.
When pythran 0.12.1 is installed, I get 24 doctest failures due to
deprecation warnings; they are all gone with this commit.
@tornaria tornaria requested a review from mkoeppe April 4, 2023 16:02
@tornaria tornaria mentioned this pull request Apr 4, 2023
4 tasks
@tornaria
Copy link
Contributor Author

tornaria commented Apr 4, 2023

And again... check failures are not my fault.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Things will get again "more interesting" when numpy drops numpy.distutils

@vbraun vbraun merged commit adaf3af into sagemath:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants