Skip to content

Activate codecov reports even if other checks are failing #35412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2023
Merged

Activate codecov reports even if other checks are failing #35412

merged 2 commits into from
Apr 6, 2023

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Apr 1, 2023 •
edited
Loading

📚 Description

Follow-up from #35056. Currently no codecov reports are displayed because the doc deployment workflow is failing and codecov by default only adds its checks if all other checks are passing. We change this setting so that codecov checks are always added, regardless of other failing tests.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tobiasdiez tobiasdiez requested a review from kwankyu April 1, 2023 16:19
mkoeppe
mkoeppe reviewed Apr 1, 2023
View reviewed changes
@kwankyu
Copy link
Collaborator

kwankyu commented Apr 2, 2023

According to https://docs.codecov.com/docs/codecovyml-reference#codecovrequire_ci_to_pass, the value is yes or no.

@tobiasdiez
Copy link
Contributor Author

According to https://docs.codecov.com/docs/codecovyml-reference#codecovrequire_ci_to_pass, the value is yes or no.

But https://docs.codecov.com/docs/common-recipe-list#see-coverage-on-ci-test-failures has it with false. I guess both yes/no and true/false are accepted. And indeed curl -X POST --data-binary @.codecov.yml https://codecov.io/validate reports it as valid.

kwankyu
kwankyu approved these changes Apr 2, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Let's deploy and see.

@vbraun vbraun merged commit 2fc44c9 into sagemath:develop Apr 6, 2023
@tobiasdiez tobiasdiez deleted the codecovalways branch April 7, 2023 06:54
@tobiasdiez
Copy link
Contributor Author

It is still not work @kwankyu how did you activate codecov in your fork? Is it still working there?

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 7, 2023

how did you activate codecov in your fork?

If I remember correctly, I changed only

Screenshot 2023-04-08 at 6 29 18 AM

Is it still working there?

Checking.

@tobiasdiez
Copy link
Contributor Author

Thanks @kwankyu for testing. I just noticed that after re-installing the codecov app here on github, everything is working fine. Sorry for the noise ;-)

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 8, 2023

Okay. Thanks for taking care of this. I am happy with codecov checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

+1 more reviewer

@mkoeppe mkoeppe mkoeppe left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasdiez @kwankyu @mkoeppe @vbraun