Skip to content

avoid computation of Conway polynomials when comparing elliptic-curve morphisms #35494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 11, 2023
Merged

avoid computation of Conway polynomials when comparing elliptic-curve morphisms #35494

merged 3 commits into from
Jun 11, 2023

Conversation

yyyyx4
Copy link
Member

@yyyyx4 yyyyx4 commented Apr 13, 2023

...to make things run faster.

Example:

sage: p = 2**127 - 1
sage: F.<i> = GF((p,2), modulus=[1,0,1])
sage: E = EllipticCurve(F, [1,0])
sage: %prun -s cumtime E.frobenius_isogeny()^2 == E.scalar_multiplication(-p)

Sage 10.0.beta8: CPU times: user 6.02 s, sys: 3.28 ms, total: 6.02 s
This branch: CPU times: user 3.89 s, sys: 3.08 ms, total: 3.89 s

@yyyyx4 yyyyx4 requested a review from remyoudompheng April 13, 2023 06:01
@yyyyx4 yyyyx4 force-pushed the public/avoid_conway_polynomials_when_comparing_elliptic_curve_morphisms branch from 3279fdf to bd8112d Compare April 14, 2023 03:13
@yyyyx4 yyyyx4 force-pushed the public/avoid_conway_polynomials_when_comparing_elliptic_curve_morphisms branch from bd8112d to 7123849 Compare May 24, 2023 05:17
kwankyu
kwankyu reviewed Jun 7, 2023
View reviewed changes
yyyyx4 added 2 commits June 7, 2023 11:09
@yyyyx4
Merge tag '10.1.beta2' into public/avoid_conway_polynomials_when_comp…
9680bfd 
…aring_elliptic_curve_morphisms

SageMath version 10.1.beta2, Release Date: 2023-06-03
@yyyyx4
reviewer comments
41490d9
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Documentation preview for this PR (built with commit 41490d9) is ready! 🎉

kwankyu
kwankyu approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vbraun vbraun merged commit 5343f2e into sagemath:develop Jun 11, 2023
@yyyyx4 yyyyx4 deleted the public/avoid_conway_polynomials_when_comparing_elliptic_curve_morphisms branch June 12, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@remyoudompheng remyoudompheng Awaiting requested review from remyoudompheng

Assignees
No one assigned
Labels
c: elliptic curves t: performance
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@yyyyx4 @kwankyu @vbraun @mkoeppe