Skip to content

adding support for subschemes in _is_preperiodic #35483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2023
Merged

adding support for subschemes in _is_preperiodic #35483

merged 4 commits into from
Jun 3, 2023

Conversation

MatheMagicianPi
Copy link
Contributor

@MatheMagicianPi MatheMagicianPi commented Apr 11, 2023 •
edited
Loading

Added and fixed documentation

📚 Description

Fixes #32338

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@EnderWannabe EnderWannabe self-requested a review June 1, 2023 20:20
@kwankyu
Copy link
Collaborator

kwankyu commented Jun 1, 2023

You do not review your own code. Please read Sage Developer Guide.

@EnderWannabe
Copy link
Contributor

You do not review your own code. Please read Sage Developer Guide.

Sorry about that - I forgot I contributed. Let me find another reviewer.

kwankyu
kwankyu approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 2, 2023

Would you fix the broken link in the PR description?

@MatheMagicianPi
Copy link
Contributor Author

Fixed.

@vbraun vbraun merged commit dc72b7f into sagemath:develop Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

+1 more reviewer

@EnderWannabe EnderWannabe EnderWannabe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: dynamics p: minor / 4
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.

adding support for subschemes in _is_preperiodic
5 participants
@MatheMagicianPi @kwankyu @EnderWannabe @vbraun @mkoeppe