Skip to content

Update GitHub transition notices in the developer manual #35482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Update GitHub transition notices in the developer manual #35482

merged 1 commit into from
Apr 13, 2023

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Apr 11, 2023 •
edited
Loading

📚 Description

Updating the developer manual with the new workflow on github would take some time. #35460 Meanwhile, we update the github transition notices in the developer manual as the transition is over now.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu changed the title Update github transition notice Update GitHub transition notice in the developer manual Apr 11, 2023
@kwankyu kwankyu changed the title Update GitHub transition notice in the developer manual Update GitHub transition notices in the developer manual Apr 11, 2023
@kwankyu kwankyu mentioned this pull request Apr 11, 2023
Merged
5 tasks
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: a4281cf

mkoeppe
mkoeppe approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating this.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Apr 11, 2023

Thanks!

@vbraun vbraun merged commit 5293320 into sagemath:develop Apr 13, 2023
@kwankyu kwankyu deleted the github-transition-is-over branch December 13, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: documentation p: critical / 2 t: enhancement
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kwankyu @mkoeppe @vbraun