Skip to content

partial cython-linting in graphs/ #35453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

partial cython-linting in graphs/ #35453

merged 1 commit into from
Apr 13, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

Used cython-lint to find some issues in graphs. Then fix some of them manually.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton fchapoton requested a review from dcoudert April 7, 2023 09:54
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 75bb6e3

dcoudert
dcoudert approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This is much cleaner this way. Thank you.

@fchapoton
Copy link
Contributor Author

merci. Il reste encore du boulot de ce type à faire dans graphs, mais pas pour aujourd'hui.

@vbraun vbraun merged commit fbe286d into sagemath:develop Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: graph theory
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe