Skip to content

fix all pycodestyle E303 warnings in rings/ #35452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix all pycodestyle E303 warnings in rings/ #35452

merged 1 commit into from
Apr 13, 2023

Conversation

fchapoton
Copy link
Contributor

📚 Description

This is fixing all pep8 E303 warnings in the rings/ folder

Purely done with autopep8.

There remains only to handle later schemes/ in another pull request and then activate the check in the linter.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 112db80

mkoeppe
mkoeppe approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Codecov failures are unrelated.

@vbraun vbraun merged commit 1af6f29 into sagemath:develop Apr 13, 2023
@fchapoton fchapoton deleted the fix_E303_in_rings branch July 16, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun