Skip to content

partial cython linting in algebras/ #35392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

partial cython linting in algebras/ #35392

merged 1 commit into from
Apr 13, 2023

Conversation

fchapoton
Copy link
Contributor

using --ignore=E501,E731,E741

📚 Description

Making use of the cython-lint command, and fixing manually the issues. Done here in algebras outside of quatalg

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton fchapoton force-pushed the cython-linting-algebras branch from efa971f to b8fa3e5 Compare March 30, 2023 17:52
@fchapoton
partial cython linting in algebras/
4700c30 
using --ignore=E501,E731,E741
@fchapoton fchapoton force-pushed the cython-linting-algebras branch from b8fa3e5 to 4700c30 Compare March 31, 2023 07:39
dcoudert
dcoudert approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit cc251ac into sagemath:develop Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dcoudert dcoudert dcoudert approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
t: refactoring
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe