Skip to content

Fix for sage -package create --pypi --source wheel #35379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2023
Merged

Fix for sage -package create --pypi --source wheel #35379

merged 1 commit into from
Apr 13, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 29, 2023

📚 Description

This adds support for platform-independent wheels that are tagged py2.py3 instead of py3.

Example: https://pypi.org/project/sphinxcontrib-jquery/#files

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

kwankyu
kwankyu approved these changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 6, 2023

Thank you!

@vbraun vbraun merged commit 54c1a2b into sagemath:develop Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: build t: bug
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun