Skip to content

Fix minimal kernel basis corner cases #35375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2023
Merged

Fix minimal kernel basis corner cases #35375

merged 2 commits into from
Apr 23, 2023

Conversation

vneiger
Copy link
Contributor

@vneiger vneiger commented Mar 28, 2023

Fixes the issues in #35258 and add relevant tests/examples

  • fix the case of the zero matrix (test d is -1 replaced by d == -1)
  • fix the case of matrices having zero columns or zero rows
  • fix the construction of the approximation order in the corner case where it may have a zero entry (e.g. constant matrix having a zero column or row), by adding 1 to this entry in such cases (the approximation order of this column/row does not matter anyway since the column/row is zero).

tscrim
tscrim approved these changes Apr 18, 2023
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tscrim tscrim added this to the sage-10.0 milestone Apr 18, 2023
@vbraun vbraun merged commit 9ff469a into sagemath:develop Apr 23, 2023
@vneiger vneiger deleted the fix_minimal_kernel_basis branch March 1, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
c: linear algebra t: bug
Projects
None yet
Milestone
sage-10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vneiger @tscrim @vbraun @mkoeppe